Issue410 osi restart#419
Merged
tdcwilliams merged 6 commits intomasterfrom Apr 27, 2020
Merged
Conversation
uninitialised drifters after restart #410
einola
approved these changes
Apr 27, 2020
Member
einola
left a comment
einola
left a comment
There was a problem hiding this comment.
Just a small change to not use std::cout - you need to change it before merging - but I didn't want to go through the "request changes" back-and-forth ;)
| { | ||
| double const restart_time = field_map_dbl["Time"][0]; | ||
| bool in_restart = false; | ||
| std::cout << M_tag << " drifters: restart time = " << restart_time << " = " << datenumToString(restart_time) << "\n"; |
Member
There was a problem hiding this comment.
Suggested change
| std::cout << M_tag << " drifters: restart time = " << restart_time << " = " << datenumToString(restart_time) << "\n"; | |
| LOG(DEBUG) << M_tag << " drifters: restart time = " << restart_time << " = " << datenumToString(restart_time) << "\n"; |
| std::cout<< M_tag<<" drifters: ignoring restart and initialising from scratch\n"; | ||
| else | ||
| in_restart = readFromRestart(field_map_int, field_map_dbl); | ||
| std::cout << M_tag << " drifters: init time = " << M_time_init << " = " << datenumToString(M_time_init) << "\n"; |
Member
There was a problem hiding this comment.
Suggested change
| std::cout << M_tag << " drifters: init time = " << M_time_init << " = " << datenumToString(M_time_init) << "\n"; | |
| LOG(DEBUG) << M_tag << " drifters: init time = " << M_time_init << " = " << datenumToString(M_time_init) << "\n"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves problem where the 2 OSISAF drifters were duplicating each other when another drifter was active and when only one was in the restart file - see #410