Conversation
Contributor
tdcwilliams
commented
Apr 30, 2020
tdcwilliams
commented
- seems to stop crash at output time flipped triangles cause crash at output #427
- was meant to stop blobs (see call FETensors each time step #400), but they are still there.
- possibly doing regridding between solve and update (or between update and thermo?) could help with that, eg the same ice volume in a very small triangle will have a huge absolute thickness which could make the fluxes very small (?)
- could also be something with treatment of open water and low-conc ice?
…mes when restarting when running at the same time as other drifters
…nter/nextsim into issue400-M_surface+flip
This reverts commit 4d4fa6e.
Conflicts: model/drifters.cpp model/finiteelement.cpp
…nter/nextsim into issue400-M_surface+flip
einola
approved these changes
May 20, 2020
tdcwilliams
added a commit
that referenced
this pull request
May 20, 2020
Merge master into develop after hotfix #430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.