Conversation
…upler (this is for the BGC model). It's called coupler.BGC_active
docguibou
approved these changes
Jul 1, 2020
Contributor
docguibou
left a comment
docguibou
left a comment
There was a problem hiding this comment.
It's good to me, but as the coupling code in neXtSIM keeps growing up we could do like in WW3 and NEMO and setup the list of exchanged variables in the configuration file. It would be clearer for the user.
tdcwilliams
approved these changes
Jul 1, 2020
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
code is probably OK, but I understand this is being run on Fram with FOSS compiler which is buggy (memory leaks), so keep this in mind and it should be tested with intel (gcc 7.3.0 is what I am using on Fram)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes made by Eric and me to enable HYCOM and bio-geo-chemical model coupling.
NB: Recieving surface layer depth through the coupler is now an option (coupler.rcv_first_layer_dept) and is off by default.