Conversation
…ar grid. This has the draw back that data must be loaded more frequently, but at least on datarmor the parallelised code is much faster. Some further testing is needed before eventual merge into develop.
docguibou
reviewed
Jul 3, 2020
Contributor
docguibou
left a comment
docguibou
left a comment
There was a problem hiding this comment.
Honestly, I don't understand much the changes in the code so I don't know if I can approve it, but I can confirm it can be compiled and run on datarmor. I also agree that it is quite faster.
tdcwilliams
approved these changes
Jul 3, 2020
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
the speed-up sounds good. Minor changes/comments - if you have the energy you could also try to remove grid_ptr throughout and swap grid_ptr-> for grid. everywhere as it is not needed.
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #434 by parallelising the loading of data that's on a regular grid. For a large number of processors, this gives a substantial gain in performance, but there could be slight performance degradation for a small number of processors.