Conversation
tdcwilliams
approved these changes
Sep 15, 2020
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
seems fine - small change suggested; also changed the PR to merge into develop not master
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
einola
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the addition of a SST_limit test to cregIce. It compiles and works on Datarmor, even though for some reasons the initialisation is different in the Hudson Bay between CREG and NANUK. After a few days however, they really look similar.