Conversation
…g). We have three cases: 1) Thermodynamics: Conserve volume of level ice. 2) Ridging of thick ice: Conserve mean thickness of level ice (or volume per ice covered area). 3) Ridging of thin ice: Conserve volume of level ice.
…idge ratio when melting (do nothing).
Member
Author
|
Ah, yes. |
docguibou
approved these changes
Dec 14, 2020
Contributor
docguibou
left a comment
docguibou
left a comment
There was a problem hiding this comment.
Ok, I understand better, thanks. Double checked quickly and normally there is no need for more "capping check", as you said (as long as conc and thick are positive at least, but well...).
einola
commented
Dec 16, 2020
As pointed out by Heather
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New ridge ratio code to address issue #442. What it does:
When ice forms (thermodynamically) we conserve the volume of ridged ice (i.e., ridges don't grow thermodynamically)
When ice melts we conserve the ridge ratio (i.e., ridges and level ice melt at the same rate).
When thick ice converges we conserve the mean thickness of level ice
When thin (young) ice converges we conserve the volume of level ice