Merged
Conversation
contributions to the fresh water ballance seperately.
Conflicts: model/finiteelement.cpp
einola
approved these changes
Mar 24, 2021
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
Co-authored-by: Einar Örn Ólason <einar.olason@nersc.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional outputs. Can be useful to everyone (I suppose)
Tested (cpl+stand_alone), seems to work.
Things that could be changed:
vice_melt could be renamed del_vi_total (or tot) to be more consistent with the naming of the variables/
del_hi and del_hi_thin are slab thickness growth/melt rates. Are they really necessary? Now that they are here, might as well leave them.