Issue483 clean explicit#526
Merged
tdcwilliams merged 14 commits intodevelopfrom Mar 26, 2021
Merged
Conversation
… physics changes that need checking.
…icates would cause a crash with an unintelligible error message,
…igma. Not much more that can be done, I think.
tdcwilliams
approved these changes
Mar 26, 2021
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
- code looks pretty good
- results were mostly the same, although there were some differences in the drift (biased slightly slower than before, with this effect having more effect in the winter)
- speed-up was impressive!
- a 1-year run dropped from 21h to 11h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up of the explicit code and a few other things. It's a lot of different things, but I hope you can have a bit of an overview anyway.
Addresses issue #483