Add mesh displacement to the mesh position in GridOutput#554
Merged
tdcwilliams merged 1 commit intomasterfrom Aug 13, 2021
Merged
Add mesh displacement to the mesh position in GridOutput#554tdcwilliams merged 1 commit intomasterfrom
tdcwilliams merged 1 commit intomasterfrom
Conversation
As GridOutput only sees the BamgMesh object then it cannot take the mesh displacement happening over a time step into account. This fix adds the mesh displacement (M_UM) as an argument to the updateGrid calls of GridOutput. This addresses issue #552 in the master branch
tdcwilliams
approved these changes
Aug 13, 2021
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
great - thanks Einar
Member
Author
|
Don't forget to update the tag to 2.0.1 |
Contributor
|
I had forgotten, but just did it - thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As GridOutput only sees the BamgMesh object then it cannot take the mesh
displacement happening over a time step into account. This fix adds the
mesh displacement (M_UM) as an argument to the updateGrid calls of
GridOutput.
This addresses issue #552 in the master branch