Wave stress output#576
Merged
tdcwilliams merged 2 commits intodevelopfrom Oct 22, 2021
Merged
Conversation
docguibou
approved these changes
Oct 22, 2021
Contributor
docguibou
left a comment
docguibou
left a comment
There was a problem hiding this comment.
Changes look ok to me.
But I have a question/comment:
In gridoutput.hpp, stress components (not only for the wave stress) are said to be "Eastward/Northward", but this is not always the case in reality, am I right?
Is there a less misleading way of calling them?
I believe NEMO call them zonal and meridian, but to me it's not much better (even though that makes me feel more cautious than Eastward/Northward).
Contributor
Author
|
will need to think about the names. Since there is an option to rotate to ns/ew orientation maybe it should be done automatically which one to use... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick PR to add wave stress to moorings output