Skip to content

Coupling with waves no lateral melting#579

Merged
docguibou merged 5 commits intodevelopfrom
coupling_with_waves_no_lateral_melting
Nov 3, 2021
Merged

Coupling with waves no lateral melting#579
docguibou merged 5 commits intodevelopfrom
coupling_with_waves_no_lateral_melting

Conversation

@docguibou
Copy link
Copy Markdown
Contributor

These are a few edits to be able to run neXtSIM coupled to a wave model (including an FSD) without having lateral melting 'on'.

What I call lateral melting is equivalent to setting melt_type==3. This activate a parameterization where the amount of lateral melting is related to the FSD.

With this branch, it is possible to use other melt_type without lateral melting, or at least a lateral melting that does not depend on the FSD. If melt occurs and M_conc /M_conc_young is reduced, the areal FSD is updated after the termo routine to account for changes in sea ice area, but its shape does not change.

Copy link
Copy Markdown
Contributor

@tdcwilliams tdcwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty nice and simple; minor changes suggested

Comment thread model/finiteelement.cpp Outdated
Comment thread model/finiteelement.cpp Outdated
Copy link
Copy Markdown
Member

@einola einola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The and vs. && comment is a bit strange. I'm surprised it compiled.

Just make sure it compiles on a setup where OASIS is defined (i.e. $USE_OASIS is set)

Comment thread model/finiteelement.cpp Outdated
docguibou and others added 2 commits November 3, 2021 10:34
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
Co-authored-by: Timothy Williams <tdcwilliams@gmail.com>
@docguibou docguibou merged commit 20a6022 into develop Nov 3, 2021
@docguibou docguibou deleted the coupling_with_waves_no_lateral_melting branch November 3, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants