Initialise ice glorys by docguibou · Pull Request #606 · nansencenter/nextsim

docguibou · 2022-08-29T14:46:22Z

Adding the possibility to initialize sea ice with GLORYS12.
For use in the Antarctic. Does not use a snow climatology (snow thickness is 0).

Compiles and run

tdcwilliams

looks fine, but some suggestions for simplifying

tdcwilliams · 2022-08-29T15:30:26Z

    M_ice_amsr2_elements_dataset.interpolated=false;
    M_ice_cs2_smos_elements_dataset.interpolated=false;
    M_ice_smos_elements_dataset.interpolated=false;
+    M_ice_glorys12_elements_dataset.interpolated=false;


not needed for initialising dataset

But other initialising datasets are here too, no ?

yep, but they don't need to be

tdcwilliams · 2022-08-29T15:31:51Z

    M_ice_nic_weekly_elements_dataset=DataSet("ice_nic_weekly_elements");
    M_ice_cs2_smos_elements_dataset=DataSet("ice_cs2_smos_elements");
    M_ice_smos_elements_dataset=DataSet("ice_smos_elements");
+    M_ice_glorys12_elements_dataset=DataSet("glorys12_elements");


could move definition to glorys12ice function since it is just used at init time (doesn't need to be a global var)

tdcwilliams · 2022-08-29T15:32:30Z


+void
+FiniteElement::glorys12Ice()
+{


add dataset definition here

tdcwilliams · 2022-08-29T15:33:35Z

+        M_conc[i] = (tmp_var>1e-14) ? tmp_var : 0.; // TOPAZ puts very small values instead of 0.
+        tmp_var=M_init_thick[i];
+        M_thick[i] = tmp_var ;
+        tmp_var=0.;//This is a test for the southern ocean
+        M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.; // TOPAZ puts very small values instead of 0.


change reference to TOPAZ in comment?

tdcwilliams · 2022-08-29T15:35:15Z

    Dataset M_ice_nic_weekly_elements_dataset;
    Dataset M_ice_cs2_smos_elements_dataset;
    Dataset M_ice_smos_elements_dataset;
+    Dataset M_ice_glorys12_elements_dataset;


don't need a global

Accidental commit of a backup file

Accidental commit of a backup file.

einola

Looks fine, but I'm confused about the apparent lack of snow in GLORYS. So, if there's snow in the files, then I added a few comments on how that should be handled.

einola · 2022-08-31T06:38:54Z

+FiniteElement::glorys12Ice()
+{
+    // Initialize the sea ice conc. and thick. from GLORYS12 reanalysis or forecast. 
+    // Snow thickness is 0 by default (used in southern ocean, with no equivalent of Warren Climatology)


Isn't there snow thickness in GLORYS? It should be because it's a reanalysis. No need for Warren, just read directly from the GLORYS file.

(I know we talked about this, but it seems my brain was in a low gear)

einola · 2022-08-31T06:42:41Z

+    Dataset ice_glorys12_elements_dataset = DataSet("glorys12_elements");
+    external_data M_init_conc   = ExternalData(&ice_glorys12_elements_dataset,M_mesh,3,false,time_init);
+    external_data M_init_thick  = ExternalData(&ice_glorys12_elements_dataset,M_mesh,4,false,time_init);
+


If there's snow in the file then:

Suggested change

external_data M_init_snowthick = ExternalData(&ice_glorys12_elements_dataset,M_mesh,5,false,time_init);

einola · 2022-08-31T06:43:51Z

+        tmp_var=0.;//This is a test for the southern ocean
+        M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.; 


If there's snow in the file then:

Suggested change

tmp_var=0.;//This is a test for the southern ocean

M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.;

tmp_var=M_init_snowthick[i];

M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.;

docguibou · 2022-10-11T06:55:44Z

Haha, ok, thanks Tim! From: Timothy Williams ***@***.***> Date: Tuesday, 30 August 2022 at 16:53 To: nansencenter/nextsim ***@***.***> Cc: Guillaume Boutin ***@***.***>, Author ***@***.***> Subject: Re: [nansencenter/nextsim] Initialise ice glorys (PR #606) @tdcwilliams commented on this pull request.

________________________________ In model/finiteelement.cpp<#606 (comment)>:

@@ -619,6 +619,7 @@ FiniteElement::assignVariables()

M_ice_amsr2_elements_dataset.interpolated=false; M_ice_cs2_smos_elements_dataset.interpolated=false; M_ice_smos_elements_dataset.interpolated=false; + M_ice_glorys12_elements_dataset.interpolated=false; yep, but they don't need to be — Reply to this email directly, view it on GitHub<#606 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5CRNDJLKRDGA77OVTAZG3V3YN7DANCNFSM576CTZ4Q>. You are receiving this because you authored the thread.Message ID: ***@***.***>

docguibou · 2022-10-11T08:24:07Z

There should be snow thickness in the model, but they haven’t made it available in the reanalysis. Maybe we can send a request to CMEMS, I suppose it would not be much work for them and they could be happy to see we use products developed at Mercator. Cheers, From: Einar Örn Ólason ***@***.***> Date: Wednesday, 31 August 2022 at 08:45 To: nansencenter/nextsim ***@***.***> Cc: Guillaume Boutin ***@***.***>, Author ***@***.***> Subject: Re: [nansencenter/nextsim] Initialise ice glorys (PR #606) @einola commented on this pull request. Looks fine, but I'm confused about the apparent lack of snow in GLORYS. So, if there's snow in the files, then I added a few comments on how that should be handled.

________________________________ In model/finiteelement.cpp<#606 (comment)>:

@@ -13021,6 +13025,53 @@ FiniteElement::smosIce()

} }//smosIce +void +FiniteElement::glorys12Ice() +{ + // Initialize the sea ice conc. and thick. from GLORYS12 reanalysis or forecast. + // Snow thickness is 0 by default (used in southern ocean, with no equivalent of Warren Climatology) Isn't there snow thickness in GLORYS? It should be because it's a reanalysis. No need for Warren, just read directly from the GLORYS file. (I know we talked about this, but it seems my brain was in a low gear)

________________________________ In model/dataset.cpp<#606 (comment)>:

+ name: "sithick",

+ dimensions: dimensions, + land_mask_defined: false, + land_mask_value: 0., + NaN_mask_defined: false, + NaN_mask_value: 0., + use_FillValue: true, + use_missing_value: true, + a: 1., + b: 0., + Units: "m", + loaded_data: loaded_data_tmp, + interpolated_data: interpolated_data_tmp, + wavDirOptions: wavdiropt_none + }; + If there's now in the file then (assuming the variable is called snthick): ⬇️ Suggested change - + + Variable snowthick={ + filename_string: "", // All variables are in the same (grid) file + name: "snthick", + dimensions: dimensions, + land_mask_defined: false, + land_mask_value: 0., + NaN_mask_defined: false, + NaN_mask_value: 0., + use_FillValue: true, + use_missing_value: true, + a: 1., + b: 0., + Units: "m", + loaded_data: loaded_data_tmp, + interpolated_data: interpolated_data_tmp, + wavDirOptions: wavdiropt_none + };

________________________________ In model/dataset.cpp<#606 (comment)>:

@@ -2566,10 +2602,12 @@ DataSet::DataSet(char const *DatasetName)

}; //VAR - std::vector<Variable> variables_tmp(3); + std::vector<Variable> variables_tmp(5); If there's snow in the file then: ⬇️ Suggested change - std::vector<Variable> variables_tmp(5); + std::vector<Variable> variables_tmp(6);

________________________________ In model/dataset.cpp<#606 (comment)>:

variables_tmp[0] = sst;

variables_tmp[1] = sss; variables_tmp[2] = mld; + variables_tmp[3] = conc; + variables_tmp[4] = thick; If there's snow in the file then: ⬇️ Suggested change - + variables_tmp[5] = snowthick; +

________________________________ In model/finiteelement.cpp<#606 (comment)>:

@@ -13021,6 +13025,53 @@ FiniteElement::smosIce()

} }//smosIce +void +FiniteElement::glorys12Ice() +{ + // Initialize the sea ice conc. and thick. from GLORYS12 reanalysis or forecast. + // Snow thickness is 0 by default (used in southern ocean, with no equivalent of Warren Climatology) + Dataset ice_glorys12_elements_dataset = DataSet("glorys12_elements"); + external_data M_init_conc = ExternalData(&ice_glorys12_elements_dataset,M_mesh,3,false,time_init); + external_data M_init_thick = ExternalData(&ice_glorys12_elements_dataset,M_mesh,4,false,time_init); + If there's snow in the file then: ⬇️ Suggested change - + + external_data M_init_snowthick = ExternalData(&ice_glorys12_elements_dataset,M_mesh,5,false,time_init);

________________________________ In model/finiteelement.cpp<#606 (comment)>:

+ tmp_var=0.;//This is a test for the southern ocean

+ M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.; If there's snow in the file then: ⬇️ Suggested change - tmp_var=0.;//This is a test for the southern ocean - M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.; + tmp_var=M_init_snowthick[i]; + M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.; — Reply to this email directly, view it on GitHub<#606 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5CRNBSG4KGNNTJJZ3BDEDV335PXANCNFSM576CTZ4Q>. You are receiving this because you authored the thread.Message ID: ***@***.***>

einola · 2022-10-11T11:20:19Z

I see. It's strange that they don't output the snow - but maybe it's just really bad!?! :)

Would be nice to send a request to them, if you know how to do that.

Guillaume Boutin and others added 6 commits August 1, 2022 10:22

compiles

f4352e4

Merge branch 'bamg-ordering' into initialise_ice_GLORYS

3543cf4

bug fixes

8b07706

Merge branch 'develop' into initialise_ice_GLORYS

5820420

Make it possible to use any ocean forcing + init with Glorys

2f18076

Merge branch 'develop' into initialise_ice_GLORYS

c917082

docguibou requested review from einola and tdcwilliams August 29, 2022 14:46

tdcwilliams approved these changes Aug 29, 2022

View reviewed changes

Guillaume Boutin and others added 4 commits August 30, 2022 15:20

removing bad commit

167e2ef

Tim suggestions

cd60761

Delete finiteelement.cpp~

7306ad8

Accidental commit of a backup file

Delete finiteelement.hpp~

c4222c3

Accidental commit of a backup file.

einola reviewed Aug 31, 2022

View reviewed changes

docguibou force-pushed the initialise_ice_GLORYS branch from 52d7722 to c4222c3 Compare September 1, 2022 09:19

docguibou merged commit 83d0636 into develop Sep 1, 2022

einola deleted the initialise_ice_GLORYS branch January 30, 2025 05:31



	external_data M_init_snowthick = ExternalData(&ice_glorys12_elements_dataset,M_mesh,5,false,time_init);

		tmp_var=0.;//This is a test for the southern ocean
		M_snow_thick[i] = (tmp_var>1e-14) ? tmp_var : 0.;

Conversation

docguibou commented Aug 29, 2022

Uh oh!

tdcwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

einola left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

docguibou commented Oct 11, 2022 via email

Uh oh!

docguibou commented Oct 11, 2022 via email

Uh oh!

einola commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants