Address issue #612 by including an if-condition in model/Makefile#613
Merged
tdcwilliams merged 1 commit intomasterfrom Sep 30, 2022
Merged
Address issue #612 by including an if-condition in model/Makefile#613tdcwilliams merged 1 commit intomasterfrom
tdcwilliams merged 1 commit intomasterfrom
Conversation
The if-condition chooses to use either -isystem or -I, depending on the value of $BOOST_DIR. This is sub-optimal, but works. We should investigate better the use of -isystem.
tdcwilliams
approved these changes
Sep 30, 2022
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
I can't quite remember what problem the -isystem was solving; I think sometimes the compiler/makefile was trying to compile 3rd party libraries (like the netcdf libraries) if they were too new/old or something like that, which would generally fail.
Maybe there is another way to do this though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The if-condition chooses to use either -isystem or -I, depending on the value of $BOOST_DIR. This is sub-optimal, but works. We should investigate better the use of -isystem.
See issue #612