Conversation
I went for approach 1 because the "prognostics" group is not properly defined in the code. Turns out that the default output of "Concentration", and "Thickness" is actually a diagnostic, because it's the sum of M_conc and M_conc_young, etc. This mixes the prognostics and diagnostics groups and in the end it was easier and quicker to implement a per-variable output, like the moorings have it. But you can still choose the bulk lists of "diagnostics" and "forcings". In fact, you cannot choose from forcing variables, because they aren't ModelVariable objects. The default output is a list of variables, same as the default outputs for the moorings. But we could want to either have the default output "None" (which means only Time is output!) or the list Tim uses for neXtSIM-F. This needs some discussion.
Contributor
|
Hi @einola - did you mean to put it into master? |
Member
Author
|
Hi @tdcwilliams. No, But ok, so the forecast doesn't need any defaults. In this case, I would prefer "None" as the default. Any thoughts @tdcwilliams, @akorosov? |
Member
Author
|
NB! In this version |
Contributor
|
I think what you have for defaults is ok, but maybe none is ok too - before yesterday I would have said if someone wants to export binaries they would want to have some variables, but maybe @akorosov is the only one using them now? |
This seems to be the most sensible option. I've also added a list of all available variables to the error message.
Member
Author
|
I've set "None" as the default now. See commit 9bcbf74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went for approach 1 because the "prognostics" group is not properly defined in the code. Turns out that the default output of "Concentration", and "Thickness" is actually a diagnostic, because it's the sum of M_conc and M_conc_young, etc. This mixes the prognostics and diagnostics groups and in the end it was easier and quicker to implement a per-variable output, like the moorings have it. But you can still choose the bulk lists of "diagnostics" and "forcings". In fact, you cannot choose from forcing variables, because they aren't ModelVariable objects.
The default output is a list of variables, same as the default outputs for the moorings. But we could want to either have the default output "None" (which means only Time is output!) or the list Tim uses for neXtSIM-F. This needs some discussion.
Link to issue #615