Default to no snapshots in output and supress a compile-time warning#653
Merged
Default to no snapshots in output and supress a compile-time warning#653
Conversation
Set the default for snapshot output to zero, and make sure this actually works!
The sub-proc numbering function should throw an error if it doesn't find what it's looking for.
tdcwilliams
approved these changes
Jul 16, 2024
Contributor
tdcwilliams
left a comment
tdcwilliams
left a comment
There was a problem hiding this comment.
Looks OK. Made a suggestion that you can commit if you like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits:
Default to no snapshots in output
Set the default for snapshot output to zero, and make sure this actually
works!
... and ...
Suppress a compile-time warning
The sub-proc numbering function should throw an error if it doesn't find
what it's looking for.