Merged
Conversation
The additional terms when incrementing the velocity should have been alpha*delu + beta*delv and alpha*delv + beta*delu and not just alpha and beta. But I don't see how this should improve things, because alpha > 1 and beta is small.
The code now follows closely Bouillon et al (2013). I also removed substantial code repetition.
Tim spotted a sign error in Hunke and Dukowicz's equation. This also impacts my mEVP implementation.
…o hotfix_mEVP_bug
…o hotfix_mEVP_bug
tdcwilliams
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was one bug in the mEVP solver implementation (in the first commit). The stress calculations for the EVP and mEVP were also confusing, so I rewrote them.
I don't understand how these fixes should improve the mEVP results - but it's worth a try!
@tdcwilliams: Can you please test these and look at the drift?