Re-enable NSKIP009 - #848
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables the Lib/test/test_super.py TestSuper test class by removing the Nanvix-specific NSKIP009 class-level skip, with the intent of restoring coverage now that the underlying __class__ cell corruption crash is believed to be resolved.
Changes:
- Removed the
NSKIP009@unittest.skipIf(support.is_nanvix, ...)guard fromTestSuper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # NSKIP009 https://github.com/nanvix/cpython/issues/477 | ||
| @unittest.skipIf(support.is_nanvix, "NSKIP009: VM crash from __class__ cell corruption") | ||
| class TestSuper(unittest.TestCase): |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Lib/test/test_super.py:50
- Removing the class-level skip decorator means
from test import supportis now unused in this file (no remaining references). Please drop the import to avoid dead code and keep test modules tidy.
class TestSuper(unittest.TestCase):
ada-x64
marked this pull request as ready for review
August 3, 2026 14:42
__class__ cell corruption crash is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #477
What
Remove NSKIP009 class guard on test_super.TestSuper.
Why
class cell corruption crash is gone.
Verified the full lifecycle on Linux.