Re-enable NSKIP013 - #850
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables a previously skipped ExceptionGroup constructor validation test on Nanvix by removing the NSKIP013 platform guard now that 32-bit argument position numbering in TypeError messages is reported to be fixed.
Changes:
- Removed the
@unittest.skipIf(support.is_nanvix, "NSKIP013: ...")decorator fromtest_bad_EG_construction__bad_message. - Removed the associated
NSKIP013tracking comment in the test file.
Suppressed comments (1)
Lib/test/test_exception_group.py:36
- Removing the Nanvix skip means
from test import supportis now unused in this file (no remainingsupport.references). Unused imports are typically flagged by linters/formatting checks; please drop the import if it’s no longer needed.
def test_bad_EG_construction__bad_message(self):
MSG = 'argument 1 must be str, not '
with self.assertRaisesRegex(TypeError, MSG):
ExceptionGroup(ValueError(12), SyntaxError('bad syntax'))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
marked this pull request as ready for review
August 3, 2026 14:42
Argument position numbers render correctly now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
What
Remove NSKIP013 guard in test_exception_group.
Why
Argument position numbers render correctly now.
Verified the full lifecycle on Linux.