Re-enable NSKIP028 - #853
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously skipped fileinput.hook_compressed() tests on Nanvix by removing the NSKIP028 Nanvix skip guards now that encoding="locale" / locale.getencoding() is expected to behave correctly there.
Changes:
- Removed
support.is_nanvixskip decorators and relatedNSKIP028comments from two compressed-file hook tests. - Allows
hook_compressed(..., mode="r")to exerciseio.TextIOWrapper(..., encoding="locale")on Nanvix for.gzand.bz2paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
marked this pull request as ready for review
August 3, 2026 14:42
locale.getencoding() works now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #508
What
Remove NSKIP028 guards in test_fileinput.
Why
locale.getencoding() works now.
Verified the full lifecycle on Linux.