[updater] F: Confine SDK contracts to clones#114
Merged
Conversation
Copy the independently verified release contract into each credential-free clone before invoking zutils, preserving zutils path confinement without adding worktree changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a354ddf-0f65-44b2-a2cb-81d4662a3587
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nanvix “update-nanvix” workflow to ensure the verified SDK contract (sdk-release.json) is located inside each consumer clone’s root (via its .git/ metadata directory) before invoking update-nanvix, satisfying zutils’ contract path confinement requirements.
Changes:
- Copy
sdk-release.jsoninto each consumer clone at$clone/.git/sdk-release.jsonprior to mutation. - Switch
UPDATE_TARGETfrom an absolute workspace path to the confined relative path.git/sdk-release.json. - Add foundation test assertions to lock in the confinement behavior in the workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/nanvix-update-nanvix.yml |
Copies the SDK contract into each clone’s .git/ and uses it as the update target to satisfy confinement. |
tests/run-tests.sh |
Adds checks ensuring the workflow keeps SDK contract paths confined to each consumer clone. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Place the verified
sdk-release.jsoninside each credential-free consumer clone's Git metadata before invokingupdate-nanvix.The first strict cascade correctly failed because zutils rejects local contract paths outside the target root.
.git/sdk-release.jsonsatisfies confinement without introducing an untracked worktree path or expanding the publication allowlist.Validation