Update dev instructions to use prek - #1096
Merged
Merged
Conversation
TimMonko
reviewed
Aug 4, 2026
| please do not ignore errors lightly. | ||
|
|
||
| ```{note} | ||
| To run `prek` manually, without creating a commit, you can run `prek run --all-files`. |
Member
There was a problem hiding this comment.
is all-files the correct thing here? Unless I've been using -a incorrectly, this lints the entire repo, causing many files to be diffed.
Contributor
Author
There was a problem hiding this comment.
-a is shorter form of --all-files.
One could just run prek run but then it only checks files staged for commit.
And as we keep pre-commit on the whole repo, then prek run --all-files should report problems only in user changed files.
Member
There was a problem hiding this comment.
I made napari/napari#9359 to address my confusion. It was line ending shenanigans cuasing all the .py files to get changed by ruff to LF (locally on windows).
Co-authored-by: Tim Monko <timmonko@gmail.com>
TimMonko
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Depends on napari/napari#9211
Description
As
prekis faster than pre-commit (for example, it uses uv to install tools), we should advertise it and use it.