Fix building docs with PyQt6 - #1102
Merged
Merged
Conversation
Member
|
@napari-bot make docs |
Contributor
Author
|
@TimMonko it builds |
TimMonko
approved these changes
Aug 10, 2026
TimMonko
left a comment
Member
There was a problem hiding this comment.
🍻 thanks for the ping! So glad to have this rolling in.
ping me when next PR is ready
This was referenced Aug 10, 2026
melissawm
pushed a commit
that referenced
this pull request
Aug 11, 2026
# References and relevant issues follow-up #1102 # Description Just change circleci configuration in napari/docs to use PyQt6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Unlock napari/shared-workflows#29
Description
The build docs against PyQt6 fails with such warnings (and we treat warnings as errors).
This PR uses our machinery to filter out problematic methods.
It improves the Qt filter mechanism to not filter outside the
napari.qtmodule