Fix #51, do not assert when NDEBUG is set#81
Merged
Conversation
This effectively ignores CF_Assert checks in the code when it is compiled with NDEBUG. None of these checks should be needed after development. In particular, this removes the use of the non-standard "unlikely" compiler extension that was used here.
This was
linked to
issues
Dec 1, 2021
Closed
Contributor
Author
jphickey
added
the
CCB:Ready
astrogeco
added
CCB:Approved
and removed
CCB:Ready
Contributor
|
CCB:2021-12-08 - APPROVED
|
Contributor
Author
|
Submitted #107 for the right fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively ignores CF_Assert checks in the code when it is compiled with NDEBUG. None of these checks should be needed after development.
In particular, this removes the use of the non-standard "unlikely" compiler extension that was used here.
Fixes #51