Skip to content

Fix #51, do not assert when NDEBUG is set #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astrogeco merged 1 commit into from
Dec 8, 2021
+15 −3
Merged

Fix #51, do not assert when NDEBUG is set #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions fsw/src/cf_assert.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,23 @@

extern void CF_HandleAssert(const char *file, int line);

/*
* Note that in some cases, code in CF may compute or store a value for the
* sole purpose of checking it with a CF_Assert(). If CF_Assert is then entirely
* compiled out with NDEBUG, the compiler may see that as an unused value and
* trigger a warning.
*
* To avoid this, a no-op inline function is used, such that the value in the
* CF_Assert call is still evaluated, but the result is ignored.
*/

#ifdef NDEBUG
/* this is release mode */
#define CF_Assert(x) \
if (unlikely((x))) \
CF_HandleAssert(__FILE__, __LINE__);
static inline void CF_NoAssert(bool cond)
{
/* no-op to avoid unused value warning */
}
#define CF_Assert(x) CF_NoAssert(x)
#else /* NDEBUG */
#include <assert.h>
#define CF_Assert(x) assert(x)
Expand Down