Skip to content

Fix downstream shock Mach numbers - #122

Merged
markleader merged 4 commits into
nasa:mainfrom
markleader:fix/shock-mach-mw
Aug 28, 2026
Merged

Fix downstream shock Mach numbers#122
markleader merged 4 commits into
nasa:mainfrom
markleader:fix/shock-mach-mw

Conversation

@markleader

Copy link
Copy Markdown
Contributor

Summary

Correct downstream Mach outputs in the Fortran shock solver.

Changes

  • Calculate Mach from finalized velocity and sound speed across equilibrium, frozen, and retained-last-valid paths.
  • Document shock reference frames and sound-speed conventions.
  • Preserve M21/M52 as molecular-weight ratios and correct misleading documentation.
  • Add physical-validation, input-mode, reuse, and failure regressions.

Testing

  • Rebuilt the Fortran library and Python extension.
  • All 15 CTest targets and 99 Python tests passed.
  • Validated incident/reflected shocks against monatomic-gas normal-shock relations.
  • All 944 captured non-Mach fields remained bitwise unchanged; legacy example output remained byte-identical.

Compatibility / Numerical behavior

  • No expected changes to numerical results
  • Expected changes: downstream Mach values are corrected. The reproducer now returns [4.171573075415, 0.689598550089, 0.662949797119]. Thermochemical states, sound-speed conventions, and legacy molecular-weight ratios remain unchanged.

@markleader
markleader merged commit 0b47b13 into nasa:main Aug 28, 2026
21 checks passed
@markleader
markleader deleted the fix/shock-mach-mw branch August 28, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant