Fix included files - #84
Merged
Merged
Conversation
ninotarantino
force-pushed
the
include-what-we-use
branch
from
August 28, 2026 16:38
06f11c6 to
1b7e8e6
Compare
ninotarantino
marked this pull request as ready for review
August 28, 2026 17:23
Collaborator
|
coverage: 89.465%. remained the same — include-what-we-use into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up
#includes as part of #63. Removed unused#includes and added ones that were missing. Also removed a majority of trailing comments like#include <string> // string.There were a fair number of models which relied on including
cml_message.hhormath_utils.hhin their header to get Trick to recognize the message and math models as dependencies. Since those headers were removed due to not being used by the header, the correct source files were added as dependencies to the model source files.Note that some files have a strange ordering for included files, so there wasn't a great way to add missing headers without reordering everything. This will be addressed in #9.