Skip to content

cherry-pick VIPERGC 659 couch search indexes #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

cherry-pick VIPERGC 659 couch search indexes #8045

merged 1 commit into from
Apr 23, 2025

Conversation

@akhenry
Copy link
Contributor

@akhenry akhenry commented Apr 23, 2025 •
edited
Loading

PR: #8037
Issue: VIPERGC-644

@akhenry
Couch search indexes (#8037)
2221eba 
* Defined search index for object names. Add index for searching by object type
* Feature detect if views are defined to support optimized search. If not, fall back on filter-based search
* Suppress github codedcov annotations for now, they are not accurate and generate noise.
* Allow nested describes. They're good.
* Add a noop search function to couch search folder object provider. Actual search is provided by Couch provider, but need a stub to prevent in-memory indexing
* Adhere to our own interface and ensure identifiers are always returned by default composition provider
@akhenry akhenry requested a review from davetsay April 23, 2025 23:04
@akhenry akhenry changed the base branch from master to gold April 23, 2025 23:05
@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (gold@3ae9d12). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...c/plugins/persistence/couch/CouchObjectProvider.js 70.83% 7 Missing ⚠️
src/plugins/CouchDBSearchFolder/plugin.js 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             gold    #8045   +/-   ##
=======================================
  Coverage        ?   57.65%           
=======================================
  Files           ?      678           
  Lines           ?    27521           
  Branches        ?     2691           
=======================================
  Hits            ?    15867           
  Misses          ?    11313           
  Partials        ?      341
Flag Coverage Δ
e2e-ci 62.71% <20.00%> (?)
e2e-full 42.02% <74.00%> (?)
unit 49.22% <28.00%> (?)
Files with missing lines Coverage Δ
src/api/composition/CompositionCollection.js 93.75% <100.00%> (ø)
src/api/composition/CompositionProvider.js 73.17% <ø> (ø)
src/api/composition/DefaultCompositionProvider.js 95.74% <100.00%> (ø)
src/api/objects/ObjectAPI.js 92.24% <100.00%> (ø)
...c/plugins/persistence/couch/CouchSearchProvider.js 88.13% <100.00%> (ø)
src/ui/layout/search/GrandSearch.vue 73.33% <ø> (ø)
src/plugins/CouchDBSearchFolder/plugin.js 82.35% <60.00%> (ø)
...c/plugins/persistence/couch/CouchObjectProvider.js 90.67% <70.83%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae9d12...2221eba. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davetsay davetsay merged commit 9c9329d into gold Apr 23, 2025
16 of 26 checks passed
@davetsay davetsay deleted the VIPERGC-659-couch-search-indexes branch April 23, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davetsay davetsay davetsay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhenry @davetsay