Add Max MTU and 2M PHY selection #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetious
force-pushed
the
facetious/add-mtu-and-2meg-phy
branch
from
11eecc4 to
0fb8f73
Compare
Member
|
@facetious seems awesome. One thing. I am a bit worried about the hardcoded MTU value on iOS for |
Contributor
Author
iOS has forced its MTU to 185 since it began supporting BLE. Is your concern that the peripheral may not support it? |
Member
|
@facetious indeed it is my concern. I am worried users will think 185 will always work. But i dont know maybe it is good still. |
Member
|
@facetious sory for looking at this so late. Can you merge from master? |
Contributor
Author
|
This was resolved by #202 (which I totally forgot was still open). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two optional parameters to
connectthat affect Android connections (these features are not available on iOS).auto2MegPhy?: boolean (default: false): When enabled, Android Oreo and newer will request that the 2M PHY be selected at the time of connect.autoMaxMTU?: boolean (default: false): When enabled, Android requests the maximum MTU (247) on the new connection.In addition to the above functional features, there are also some non-breaking extensions to the response structures.
Peripheral.mtuis added, helping clients toWriteWithoutResponsedata in appropriate chunk sizes.ReadResult.peripheralUUIDis added (viaextends CRUDOptions) to enable clients to connect notify streams to multiple peripherals at the same time.