Android high-velocity connections #202
Conversation
|
@facetious i love it. One change request though. All CLog calls (even erros ) should remain between "if Trace.isEnabled". This is very important in production. If not CLog method arguments will still be evaluated which can be slow and unnecessary. The if is also used to remove the code completely using webpack . |
…lso removes code duplication by introducing attachSubDelegate.
facetious
force-pushed
the
facetious/multi-notify-listeners
branch
from
8d0084f to
e7dee52
Compare
|
No problem. Cleaned up the remaining ones that I missed and squashed it together. |
|
@facetious ok great so it is ready to merge from your perspective? if so i will merge it right now and test later on (that way we dont end up in the same case as last time). |
|
I've been using it here locally on iOS and Android and it seems to function as expected. If that's enough for you, then it's good for me. :) |
|
Enough for now. Won't release yet though. Have a few projects I can test that on. |
2 participants
This updates the Android implementation to introduce
attachSubDelegatefunction, reducing code duplication. Using this, 2M PHY selection and Max MTU is also made available.Making sure to mirror the change to the response on iOS, the MTU is reported as the fixed value of 185.