Fixing typescript breakpoints on windows #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- vscode seems to handle 'drive-letter' in both small letter and capital letter, this makes some conflict while dealing with breakpoints. Currently the _sourceMaps tree in sourceMapTransformer.ts has all paths with small letter but on the setBreakpoints method the debugger adapter receives capital letter. - Use tree-kill to kill the tns process because process kill throws an error "Unknown signal: SIGQUIT". Also on windows only the parent process is killed which in our case is the shell process which has started the "tns debug command". The actual node process remains. - Increase time before "readyForConnection" event because in my tests it seems that 500 milliseconds are not enough. - Remove some obsolete properties from launch.json and added a composite configuration for easier start/debugging.
bundyo
approved these changes
May 8, 2018
tsvetie
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode seems to handle 'drive-letter' in both small letter and capital letter, this makes some conflict while dealing with breakpoints. Currently the _sourceMaps tree in sourceMapTransformer.ts has all paths with small letter but on the setBreakpoints method the debugger adapter receives a capital letter.
Use tree-kill to kill the tns process because process kill throws an error "Unknown signal: SIGQUIT". Also on windows only the parent process is killed which in our case is the shell process which has started the "tns debug command". The actual node process remains.
Increase time before "readyForConnection" event because in my tests it seems that 500 milliseconds are not enough.
Remove some obsolete properties from launch.json and added a composite configuration for easier start/debugging.