Skip to content

Added syncAllFiles option #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzraikov merged 1 commit into from
Aug 2, 2016
Merged

Added syncAllFiles option #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@
"sourceMaps": true,
"diagnosticLogging": false,
"emulator": false,
"rebuild": false
"rebuild": false,
"syncAllFiles": false
},
{
"name": "Launch on iOS",
Expand Down Expand Up @@ -223,6 +224,11 @@
"type": "boolean",
"description": "Whether the app should be rebuild before start.",
"default": true
},
"syncAllFiles": {
Copy link
Contributor

@blagoev blagoev Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind we rename this to "syncModules", syncModuleFiles, syncNodeModules... or something like that.

syncAllFiles is too generic and one needs to read the description to know what that does. the CLI flag is holding off the same I think.

@ivanbuhov @tzraikov

Copy link
Contributor Author

@tzraikov tzraikov Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncNodeModules sounds good. We have not documented this option in CLI, still it could affect existing users of VSC extension. Do you want this change in release?

@hshristov

Copy link
Contributor

@blagoev blagoev Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep we can rename this before releasing. to avoid "braking change" it later

@hshristov

"type": "boolean",
"description": "Whether to sync files from node_modules folder.",
"default": false
}
}
},
Expand Down
1 change: 1 addition & 0 deletions src/debug-adapter/webKitAdapterInterfaces.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface ILaunchRequestArgs extends DebugProtocol.LaunchRequestArguments
tnsArgs?: string[];
tnsOutput?: string;
rebuild?: boolean;
syncAllFiles?: boolean;
}

export interface IAttachRequestArgs extends DebugProtocol.AttachRequestArguments {
Expand Down
1 change: 1 addition & 0 deletions src/services/NsCliService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export class IosProject extends NSProject {
.appendParamIf("--start", args.request === "attach")
.appendParamIf("--debug-brk", args.request === "launch")
.appendParamIf("--no-rebuild", !rebuild)
.appendParamIf("--syncAllFiles", args.request === "launch" && !rebuild && (args as ILaunchRequestArgs).syncAllFiles)
.appendParam("--no-client")
.appendParams(args.tnsArgs)
.build();
Expand Down