This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Copy the hooks folder into dist #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being one of those. This change copies the hooks folder (if any) to the dist folder. Without this change, the Firebase plugin will not run at all on Android, and have trouble with certain features on iOS. Also, users can now add their own hooks to the root /hooks folder, and those are picked up as well.
Contributor
|
+1 |
Contributor
|
The hooks folder is usually created / populated when the plugin is installed (i.e. postinstall hook) so it should get created when the dist folder is prepared. The problem right now is dist is not re-prepared when adding plugin, which should be fixed in the 0.3.0 branch. I'm not against committing this against the master branch, but it would be good to move forward to 0.3.0 someday.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many plugins use hooks to run before/after prepare scripts. Firebase being one of those. This change copies the hooks folder (if any) to the dist folder. Without this change, the Firebase plugin will not run at all on Android and have trouble with certain features on iOS.
Also, users can now add their own hooks to the root /hooks folder, and those are picked up as well.
Note that this feature was added in #6, but it seems it got lost in recent refactorings.