fix: scrollview not working with automatic transform #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Replaces the previously direct re-export of react-native's ScrollView with a local implementation, presumably to fix issues with automatic transform logic.
- Adds getter returning ./ScrollView.ScrollView
- Removes prior getter returning react-native ScrollView
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| get ScrollView() { | ||
| return require("./ScrollView").ScrollView; | ||
| }, |
There was a problem hiding this comment.
This changes the public API from directly re-exporting react-native's ScrollView to a custom implementation. If the custom ScrollView does not maintain full prop/behavior parity (e.g., forwarded ref handling, static members, scroll event props), this could be a breaking change. Consider confirming parity, documenting the change, or providing a transitional alias to avoid unexpected regressions.
Suggested change
| }, | |
| }, | |
| // Transitional alias for the original react-native ScrollView | |
| get RNScrollView() { | |
| return require("./ScrollView").RNScrollView; | |
| }, |
Contributor
Author
Merge activity
|
marklawlor
deleted the
10-01-fix_scrollview_not_working_with_automatic_transform
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.