Skip to content

fix: scrollview not working with automatic transform #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix: scrollview not working with automatic transform #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/index.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ module.exports = {
get Pressable() {
return require("./Pressable").Pressable;
},
get ScrollView() {
return require("./ScrollView").ScrollView;
},
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the public API from directly re-exporting react-native's ScrollView to a custom implementation. If the custom ScrollView does not maintain full prop/behavior parity (e.g., forwarded ref handling, static members, scroll event props), this could be a breaking change. Consider confirming parity, documenting the change, or providing a transitional alias to avoid unexpected regressions.

Suggested change
},
},
// Transitional alias for the original react-native ScrollView
get RNScrollView() {
return require("./ScrollView").RNScrollView;
},

Copilot uses AI. Check for mistakes.
get Switch() {
return require("./Switch").Switch;
},
Expand Down Expand Up @@ -71,9 +74,6 @@ module.exports = {
get SafeAreaView() {
return require("react-native").SafeAreaView;
},
get ScrollView() {
return require("react-native").ScrollView;
},
get SectionList() {
return require("react-native").SectionList;
},
Expand Down