fix: emit native injection code as CommonJS - #419
Open
shin4141 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require()callsStyleCollection.injectbehaviorThe synthetic module previously retained raw
import/exportsyntax, which reaches Hermes unchanged when Expo's optimize-graph tree shaking is enabled.Validation
yarn lintyarn typecheckyarn buildgit diff --checkThe exact Expo optimize-graph + Hermes export was not rerun locally; the regression directly covers the script-mode parse failure and the required module/injection behavior.
Closes #414.
AI assistance was used to inspect the issue, implement the focused change, and run validation. I reviewed the complete diff.