test(file_type): add URL-form identity regression tests (ITL-474) by kurodo3[bot] · Pull Request #211 · nauticalab/orcapod-python

kurodo3 · 2026-07-07T04:49:03Z

Summary

Audit result for ITL-474: op.File already preserves URL-form identity correctly at every layer — no production code changes needed.

This PR adds regression tests that lock in that behaviour:

TestURLFormIdentity (5 tests) in tests/test_extension_types/test_file_type.py: covers str(), hash() stability, hash equals hash((protocol, vfspath)), LogicalFile.python_to_storage() encoding, and LogicalFile round-trip.
test_cache_key_preserves_url_form in tests/test_hashing/test_file_hashers.py: confirms CachedFileHasher does not resolve URL-form paths to concrete backend paths when building the FileHashKey.

Both test classes use memory:// (always-available fsspec protocol) as a stand-in for engm://.

Closes ITL-474

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…Identity (ITL-474)

…eHasher (ITL-474)

…L-474)

codecov · 2026-07-07T04:50:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Adds regression coverage for ITL-474 to ensure op.File (UPath-based) preserves URL-form identity for non-local fsspec protocols (using memory:// as a stand-in), and documents the audit findings and test plan.

Changes:

Add TestURLFormIdentity to validate File string/hash() behavior and LogicalFile serialization round-trips for URL-form paths.
Add a CachedFileHasher regression test to ensure the cache key retains the original URL-form path.
Add supporting design/spec and implementation plan documents for the audit and tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
tests/test_extension_types/test_file_type.py	Adds `memory://`-backed regression tests for URL-form identity across `File` and `LogicalFile`.
tests/test_hashing/test_file_hashers.py	Adds a regression test ensuring `CachedFileHasher` cache keys preserve URL-form paths.
superpowers/specs/2026-07-07-itl-474-opfile-url-form-identity-design.md	Records audit findings and specifies the regression tests added in this PR.
docs/metamorphic/plans/2026-07-07-itl-474-opfile-url-form-identity.md	Implementation plan documenting how to add/verify the regression tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kurodo3 · 2026-07-07T05:42:55Z

+    def test_hash_equals_upath_protocol_tuple(self):
+        # UPath.__hash__ = hash((protocol, vfspath))
+        # For memory://ns/x.bin: protocol="memory", vfspath="/ns/x.bin"
+        # This test pins the exact hash contract so any regression is immediately visible.
+        expected = hash(("memory", "/ns/x.bin"))
+        actual = hash(File("memory://ns/x.bin"))
+        assert actual == expected, (
+            f"hash(File('memory://ns/x.bin')) should equal hash(('memory', '/ns/x.bin')), "
+            f"got {actual} vs {expected}"
+        )


Fixed — replaced the hard-coded hash(("memory", "/ns/x.bin")) with hash(UPath("memory://ns/x.bin")). The test now derives the expected value directly from UPath, so it stays focused on verifying that File follows the same hash contract as its wrapped UPath rather than asserting against a specific internal representation.

kurodo3 · 2026-07-07T05:43:06Z

+            cached.hash_file(UPath("memory://ns/cache_key_test.bin"))
+
+            keys = list(cacher._cache.keys())
+            assert len(keys) == 1, f"Expected 1 cache entry, got {len(keys)}"
+            key = keys[0]
+            assert str(key.path) == "memory://ns/cache_key_test.bin", (
+                f"Cache key path must preserve URL form; got {str(key.path)!r}"
+            )


Fixed — removed the cacher._cache inspection. The test now reconstructs the expected FileHashKey using url_path.resolve() + stat() (mirroring exactly what CachedFileHasher does internally), then verifies a cache hit via the public cacher.get() API. The URL-form assertion then checks str(expected_key.path) on that reconstructed key, which confirms the key path was not resolved to a concrete backend path.

kurodo3 · 2026-07-07T05:43:12Z

+| Test class | File | What it covers |
+|---|---|---|
+| `TestURLFormIdentity` | `tests/test_extension_types/test_file_type.py` | `str()`, `hash()`, `LogicalFile` round-trip |
+| `TestCachedFileHasherURLKey` (new method in existing class) | `tests/test_hashing/test_file_hashers.py` | `CachedFileHasher` cache-key URL preservation |
+


Fixed — updated the table entry to reference the actual test: TestCachedFileHasher.test_cache_key_preserves_url_form.

kurodo3 · 2026-07-07T05:43:13Z

+| Test | Assertion |
+|---|---|
+| `test_cache_key_preserves_url_form` | After hashing `memory://ns/x.bin`, the `FileHashKey.path` in the cache has `str(key.path) == "memory://ns/x.bin"` |


Fixed — updated the example path to memory://ns/cache_key_test.bin to match the implemented test.

- Replace fs.store membership checks with fs.exists() public API in TestURLFormIdentity fixture (avoids fsspec internals) - Derive expected hash from UPath directly in test_hash_equals_upath_protocol_tuple (no hard-coded vfspath string) - Replace cacher._cache inspection with FileHashKey reconstruction + cacher.get() in test_cache_key_preserves_url_form (uses public API) - Fix spec doc: correct TestCachedFileHasher test name and example path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

kurodo3 · 2026-07-07T05:43:24Z

Review round summary

All 5 Copilot comments addressed in commit ed3f1d3.

Comment	Change
Fixture uses `fs.store` (internal attribute)	Replaced both `if "/ns/x.bin" in fs.store:` guards with `if fs.exists("/ns/x.bin"):` — uses the public fsspec API
`test_hash_equals_upath_protocol_tuple` hard-codes `"/ns/x.bin"`	Replaced `hash(("memory", "/ns/x.bin"))` with `hash(UPath("memory://ns/x.bin"))` — derives expected value from UPath directly
`test_cache_key_preserves_url_form` inspects `cacher._cache`	Replaced private-dict inspection with `FileHashKey` reconstruction + `cacher.get()` public API
Spec table names the test `TestCachedFileHasherURLKey`	Updated to `TestCachedFileHasher.test_cache_key_preserves_url_form`
Spec shows `memory://ns/x.bin` for the cache-key test	Updated to `memory://ns/cache_key_test.bin` to match the implemented test

All 6 affected tests still pass.

…ity-preservation-for-engmfs

kurodo3 Bot and others added 6 commits July 7, 2026 04:27

docs(specs): add ITL-474 op.File URL-form identity audit design spec

a424eff

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs(plans): add ITL-474 op.File URL-form identity regression tests plan

8ec081c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(file_type): add TestURLFormIdentity regression tests (ITL-474)

9ab558c

test(file_type): fix fixture teardown and import style in TestURLForm…

e0ba5d4

…Identity (ITL-474)

test(file_hashers): add URL cache-key preservation test for CachedFil…

eae37ba

…eHasher (ITL-474)

test(file_hashers): move fsspec and UPath imports to module level (IT…

23e237b

…L-474)

eywalker approved these changes Jul 7, 2026

View reviewed changes

eywalker requested a review from Copilot July 7, 2026 05:21

Copilot started reviewing on behalf of eywalker July 7, 2026 05:22 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

eywalker approved these changes Jul 7, 2026

View reviewed changes

Merge branch 'main' into eywalker/itl-474-opfile-audit-url-form-ident…

badfea2

…ity-preservation-for-engmfs

eywalker merged commit f60f49d into main Jul 7, 2026
11 checks passed

eywalker deleted the eywalker/itl-474-opfile-audit-url-form-identity-preservation-for-engmfs branch July 7, 2026 05:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(file_type): add URL-form identity regression tests (ITL-474)#211

test(file_type): add URL-form identity regression tests (ITL-474)#211
eywalker merged 8 commits into
mainfrom
eywalker/itl-474-opfile-audit-url-form-identity-preservation-for-engmfs

kurodo3 Bot commented Jul 7, 2026

Uh oh!

codecov Bot commented Jul 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

kurodo3 Bot Jul 7, 2026

Uh oh!

kurodo3 Bot Jul 7, 2026

Uh oh!

kurodo3 Bot Jul 7, 2026

Uh oh!

kurodo3 Bot Jul 7, 2026

Uh oh!

kurodo3 Bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kurodo3 Bot commented Jul 7, 2026

Summary

Uh oh!

codecov Bot commented Jul 7, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

kurodo3 Bot Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

kurodo3 Bot Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

kurodo3 Bot Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

kurodo3 Bot Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

kurodo3 Bot commented Jul 7, 2026

Review round summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants