Add id to index form - #2123
Merged
Merged
Conversation
Without an id, LiveView cannot perform form recovery after a crash or disconnect, which Phoenix.LiveViewTest reports as a warning. The id mirrors the one already used for the index form input, so it is unique per field and item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index forms rendered by the built-in fields carry
phx-changebut noid. Without an id LiveView cannot perform form recovery after a crash or disconnect, andPhoenix.LiveViewTestreports amissing_form_idwarning for every render.This follows #2122 (per-page select form) and #2089 (filter form), which fixed the same class of warning elsewhere.
Changes
Adds an
idto the index form in the nine fields that render one:belongs_to,boolean,date,date_time,email,number,select,text,time.The id reuses the expression already used for the index form input directly below it:
That keeps it unique per field and per item, and correct for resources with a custom or composite primary key.
Also adds an
idto the<.form>in theedit_card/1doc example, so the documented pattern doesn't demonstrate the thing that triggers the warning.Verification
mix lint— compile with--warning-as-errors, format, and credo all cleanMIX_ENV=test mix test— 100 doctests, 174 tests, 0 failures