Match assembly identity to what callers look up - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places where fcs-fable disagrees with FCS about an assembly's name. Both only bite when the IL module name differs from the name callers use, which never happens for ordinary assemblies - but
fable precompilewritesFable.Precompiled.dllfrom a project called something else, and its module calls itselfFable.Precompiled.exe.1. CCU name (
GetCcuFS)FCS names a CCU from the signature-data resource -
CompilerImports.fsdoesCcuThunk.Create(ccuName, ccuData)withccuNamefromGetResourceNameAndSignatureDataFuncs. fcs-fable usedilModule.ManifestOfAssembly.Name.Pickled data refers to its own CCU by the name it was pickled under. Registered under the manifest name, that reference stays an unresolved thunk and any type reached through it raises
UnresolvedPathReferenceNoRangewhile type-checking.2. Assembly file name (
LoadMod,LoadSigData,LoadOptData,GetCcuIL,GetCcuFS)ccuData.FileNamewasilModule.Name. There is no file system here - an assembly is known by the name handed toreadAllBytes- so anything looking one up by path misses. Concretely,TryGetEntity's fallback into a precompiled assembly always returnedNone.Effect
Referencing a
fable precompileassembly from fable-standalone works. Before, it failed on any type that assembly defined.Consumed by fable-compiler/Fable#4898, where
./build.sh test standaloneis green (3076 tests).