Fix: prevent Solr initialization from clearing index data#185
Merged
Conversation
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Solr connector initialization from clearing existing index documents as a side effect of
force: true.Changes
reset_schema!SolrConnector#init(true)is calledWhy
force: truewas used by callers to refresh/reinitialize Solr connections and schema state. Before this change, that path calledinit_schema, which unconditionally cleared all documents from the resolved Solr collection.For alias-backed search collections, this could wipe the physical collection behind an alias during routine indexing workflows.
Verification
Added regression coverage in
test/solr/test_solr.rb:test_force_init_preserves_existing_documentsindexes a document, callsSolrConnector#init(true), and asserts the document remains in the collection.Targeted test run: