Expand user search fields#226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/users?search=behavior: default search remains username-only for backward compatibility.search_fieldsparam so clients can opt into searching specific fields:username,email,firstName, and/orlastName.search_fields=allshorthand for searching all supported user search fields.allvalues such assearch_fields=all,email;allmust be used by itself.allhandling, and no-match pagination metadata.Minitest::Reporterswhen tests are launched from RubyMine so IDE test runs can use RubyMine's reporter.Notes
BioPortal Admin Users can pass
search_fields=allto search across all user table fields. Existing clients, including remote account pickers that expect username-only matching, can omitsearch_fields.Verification
ruby -c helpers/users_helper.rbruby -c test/controllers/test_users_controller.rbbundle exec ruby test/controllers/test_users_controller.rbCloses #225