Skip to content

Improve file copy error handling and post-copy verification in copy_file_repository#243

Merged
alexskr merged 1 commit intodevelopfrom
fix/repository-permissions-modes
Jul 8, 2025
Merged

Improve file copy error handling and post-copy verification in copy_file_repository#243
alexskr merged 1 commit intodevelopfrom
fix/repository-permissions-modes

Conversation

@alexskr
Copy link
Member

@alexskr alexskr commented Jun 30, 2025

Improve file copy error handling and post-copy verification in copy_file_repository

  • Replace shallow raise that discarded original exception type and backtrace with raise using e.class, custom message, and e.backtrace
  • Move File.exist? check outside of begin-rescue to avoid catching assertion errors unrelated to mkdir, chmod, or copy
  • Raise IOError for missing post-copy file to clarify semantics

follow up to #240

- Replace shallow raise that discarded original exception type and backtrace
  with raise using e.class, custom message, and e.backtrace
- Move File.exist? check outside of begin-rescue to avoid catching assertion errors unrelated to mkdir, chmod, or copy
- Raise IOError for missing post-copy file to clarify semantics
@alexskr alexskr marked this pull request as ready for review June 30, 2025 18:30
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.39%. Comparing base (867f9bc) to head (29171a0).
Report is 44 commits behind head on develop.

Files with missing lines Patch % Lines
...tologies_linked_data/models/ontology_submission.rb 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
+ Coverage    79.89%   80.39%   +0.49%     
===========================================
  Files           75       75              
  Lines         5511     6008     +497     
===========================================
+ Hits          4403     4830     +427     
- Misses        1108     1178      +70     
Flag Coverage Δ
unittests 80.39% <60.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexskr alexskr merged commit 76c1c82 into develop Jul 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant