Fix issue with failing to pass kernel limit parameter to density estimation constructor.#21
Merged
ncguilbeault merged 2 commits intomainfrom Feb 23, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new property
KernelLimitto thePointProcessModelConfigurationand integrates it into various classes and methods across the codebase. The most important changes include adding theKernelLimitproperty, updating constructors, and modifying methods to utilize this new property.Key Changes:
Addition of
KernelLimitProperty:src/PointProcessDecoder.Core/Configuration/PointProcessModelConfiguration.cs: Added theKernelLimitproperty to thePointProcessModelConfigurationclass.Updates to
ClusterlessMarkEncoder:src/PointProcessDecoder.Core/Encoder/ClusterlessMarkEncoder.cs: Added thekernelLimitparameter to theKernelDensityconstructor calls within theClusterlessMarkEncoderclass. [1] [2]src/PointProcessDecoder.Core/Encoder/ClusterlessMarkEncoder.cs: Changed_channelEstimatesto be a readonly field.Updates to
SortedSpikeEncoder:src/PointProcessDecoder.Core/Encoder/SortedSpikeEncoder.cs: Added thekernelLimitparameter to theKernelDensityconstructor call within theGetEstimationMethodmethod.Updates to
PointProcessModel:src/PointProcessDecoder.Core/PointProcessModel.cs: Added theKernelLimitparameter to thePointProcessModelconstructor and theSavemethod. [1] [2]