Skip to content

Fix issue with failing to pass kernel limit parameter to density estimation constructor. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncguilbeault merged 2 commits into from
Feb 23, 2025
Merged

Fix issue with failing to pass kernel limit parameter to density estimation constructor. #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d4a11
Fixed issue when constructing density estimation without passing kern…
ncguilbeault Feb 19, 2025
8a11304
Made channel estimates readonly
ncguilbeault Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/PointProcessDecoder.Core/Configuration/PointProcessModelConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ public class PointProcessModelConfiguration
/// </summary>
public double? SigmaRandomWalk { get; set; }

/// <summary>
/// The kernel limit of the model.
/// </summary>
public int? KernelLimit { get; set; }

/// <summary>
/// The scalar type of the model.
/// </summary>
Expand Down
6 changes: 4 additions & 2 deletions src/PointProcessDecoder.Core/Encoder/ClusterlessMarkEncoder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class ClusterlessMarkEncoder : ModelComponent, IEncoder
private Tensor _markIntensities = empty(0);
private Tensor _channelIntensities = empty(0);
private Tensor _observationDensity = empty(0);
private Tensor[] _channelEstimates = [];
private readonly Tensor[] _channelEstimates = [];

private Tensor _spikeCounts = empty(0);
private Tensor _samples = empty(0);
Expand Down Expand Up @@ -98,6 +98,7 @@ public ClusterlessMarkEncoder(
_observationEstimation = new KernelDensity(
bandwidth: observationBandwidth,
dimensions: _stateSpace.Dimensions,
kernelLimit: kernelLimit,
device: device,
scalarType: scalarType
);
Expand All @@ -106,7 +107,8 @@ public ClusterlessMarkEncoder(
{
_markEstimation[i] = new KernelDensity(
bandwidth: bandwidth,
dimensions: jointDimensions,
dimensions: jointDimensions,
kernelLimit: kernelLimit,
device: device,
scalarType: scalarType
);
Expand Down
1 change: 1 addition & 0 deletions src/PointProcessDecoder.Core/Encoder/SortedSpikeEncoder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ private static IEstimation GetEstimationMethod(
EstimationMethod.KernelDensity => new KernelDensity(
bandwidth: bandwidth,
dimensions: dimensions,
kernelLimit: kernelLimit,
device: device,
scalarType: scalarType
),
Expand Down
2 changes: 2 additions & 0 deletions src/PointProcessDecoder.Core/PointProcessModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ public PointProcessModel(
DistanceThreshold = distanceThreshold,
IgnoreNoSpikes = ignoreNoSpikes,
SigmaRandomWalk = sigmaRandomWalk,
KernelLimit = kernelLimit,
ScalarType = scalarType
};
}
Expand Down Expand Up @@ -272,6 +273,7 @@ public override void Save(string basePath)
distanceThreshold: configuration.DistanceThreshold,
ignoreNoSpikes: configuration.IgnoreNoSpikes,
sigmaRandomWalk: configuration.SigmaRandomWalk,
kernelLimit: configuration.KernelLimit,
device: device,
scalarType: configuration.ScalarType
);
Expand Down