ci: automatic draft release creation on tag push#2674
Conversation
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| group: retag-launcher-${{ github.ref }} |
There was a problem hiding this comment.
this is needed as there was a collision when calling from another workflow
691a7f9 to
1d4ef3d
Compare
Code ReviewReviewed the new The changes are clean: existing retag workflows are extended with No critical issues found. ✅ |
1d4ef3d to
2b23cb7
Compare
SimonRastikian
left a comment
There was a problem hiding this comment.
This looks good to me. I couldnt find however where the CI triggers when a tag is created (whether on main or in a branch)
it applies when a tag is pushed anywhere |
netrome
left a comment
There was a problem hiding this comment.
Nice stuff! Looking forward to seeing this in action!
| SOURCE_TAG: ${{ inputs.source-tag }} | ||
| RELEASE_TAG: ${{ inputs.release-tag }} |
There was a problem hiding this comment.
Is this needed or is this just a nice to have simplification?
There was a problem hiding this comment.
I think it might be, because of workflow_call, it is used like this in the examples at least.
| if [ ! -s release-notes-raw.md ]; then | ||
| echo "::error::No changelog found for version ${VERSION} in CHANGELOG.md" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Hmm, I wonder if it would make sense to generate the changelog here with git-cliff. But I think this is fine for now. I also want to keep our actions as simple as possible.
Co-authored-by: SimonRastikian <43679791+SimonRastikian@users.noreply.github.com> Co-authored-by: netrome <22524681+netrome@users.noreply.github.com>
Closes #1971, supersedes #2203
This was tested in https://github.com/near/mpc-release-test
with release in https://github.com/near/mpc-release-test/releases/tag/untagged-c32331a90dc143d4acc8