Skip to content

ci: automatic draft release creation on tag push#2674

Merged
gilcu3 merged 1 commit intomainfrom
gilcu3/gh-action-release-automation
Apr 1, 2026
Merged

ci: automatic draft release creation on tag push#2674
gilcu3 merged 1 commit intomainfrom
gilcu3/gh-action-release-automation

Conversation

@gilcu3
Copy link
Copy Markdown
Contributor

@gilcu3 gilcu3 commented Mar 31, 2026


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
group: retag-launcher-${{ github.ref }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed as there was a collision when calling from another workflow

@gilcu3 gilcu3 force-pushed the gilcu3/gh-action-release-automation branch 2 times, most recently from 691a7f9 to 1d4ef3d Compare March 31, 2026 15:37
@gilcu3 gilcu3 marked this pull request as ready for review March 31, 2026 15:40
@claude
Copy link
Copy Markdown

claude bot commented Mar 31, 2026

Code Review

Reviewed the new release.yml workflow and the modifications to docker_launcher_release.yml and docker_node_release.yml.

The changes are clean: existing retag workflows are extended with workflow_call triggers, github.event.inputs correctly updated to inputs (works for both dispatch and call contexts), concurrency groups hardcoded to avoid collisions, and the new release orchestrator handles both tag-push and merged-release-PR triggers with proper semver validation.

No critical issues found.

@gilcu3 gilcu3 changed the title ci: automatic release tag creation on release branch merge ci: automatic draft release creation on tag push Mar 31, 2026
@gilcu3 gilcu3 force-pushed the gilcu3/gh-action-release-automation branch from 1d4ef3d to 2b23cb7 Compare March 31, 2026 15:48
Copy link
Copy Markdown
Contributor

@SimonRastikian SimonRastikian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I couldnt find however where the CI triggers when a tag is created (whether on main or in a branch)

@gilcu3
Copy link
Copy Markdown
Contributor Author

gilcu3 commented Apr 1, 2026

This looks good to me. I couldnt find however where the CI triggers when a tag is created (whether on main or in a branch)

it applies when a tag is pushed anywhere

on:
  push:
    tags:
      - '*.*.*'

Copy link
Copy Markdown
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Looking forward to seeing this in action!

Comment on lines +62 to +63
SOURCE_TAG: ${{ inputs.source-tag }}
RELEASE_TAG: ${{ inputs.release-tag }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or is this just a nice to have simplification?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be, because of workflow_call, it is used like this in the examples at least.

if [ ! -s release-notes-raw.md ]; then
echo "::error::No changelog found for version ${VERSION} in CHANGELOG.md"
exit 1
fi
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder if it would make sense to generate the changelog here with git-cliff. But I think this is fine for now. I also want to keep our actions as simple as possible.

@gilcu3 gilcu3 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 31c6b37 Apr 1, 2026
26 checks passed
@gilcu3 gilcu3 deleted the gilcu3/gh-action-release-automation branch April 1, 2026 20:30
Copilot AI pushed a commit that referenced this pull request Apr 8, 2026
Co-authored-by: SimonRastikian <43679791+SimonRastikian@users.noreply.github.com>
Co-authored-by: netrome <22524681+netrome@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an automated bash script for the Release

3 participants