Merged
Conversation
gilcu3
commented
Apr 2, 2026
Comment on lines
-11
to
-15
| pull_request: | ||
| branches: | ||
| - main | ||
| types: | ||
| - closed |
Contributor
Author
There was a problem hiding this comment.
this is a simplification, the idea is to trigger on tag push only, as mentioned in the updated doc
Collaborator
There was a problem hiding this comment.
Oh I missed that this was still around
|
Review: CI workflow simplification No critical issues found. The changes correctly simplify the release workflow by removing the ✅ Approved |
netrome
previously approved these changes
Apr 2, 2026
Comment on lines
-11
to
-15
| pull_request: | ||
| branches: | ||
| - main | ||
| types: | ||
| - closed |
Collaborator
There was a problem hiding this comment.
Oh I missed that this was still around
gilcu3
force-pushed
the
2690-ci-fix-release-workflow-permissions-and-simplify-trigger
branch
from
f5ed949 to
5313111
Compare
netrome
previously approved these changes
Apr 2, 2026
netrome
approved these changes
Apr 2, 2026
anodar
approved these changes
Apr 2, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gilcu3
deleted the
2690-ci-fix-release-workflow-permissions-and-simplify-trigger
branch
Copilot AI
pushed a commit
that referenced
this pull request
Apr 8, 2026
Co-authored-by: netrome <22524681+netrome@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2690
Follow-up to #2674