feat: adding reconstruction threshold in node by SimonRastikian · Pull Request #3640 · near/mpc

SimonRastikian · 2026-06-22T10:19:01Z

…same number of participants

… possible value due to 60%-80% range

…pper cap

…_bound as helpers

…nstructionthreshold

…inator) Colleagues did not agree on an 80% upper bound for the GovernanceThreshold, so set MAX_THRESHOLD_NUMERATOR = MAX_THRESHOLD_DENOMINATOR (5/5 = 100%). The relative upper cap structure is kept but never binds below the absolute `k <= n` check, so the GovernanceThreshold may again go up to the participant count. The cross-domain rule (GovernanceThreshold >= max(ReconstructionThreshold)) is unchanged. Revert the test changes that were only needed to satisfy the 80% cap (dropping thresholds / raising participant counts) and remove the now-meaningless dedicated upper-cap tests: - thresholds.rs: restore 5/5-participant thresholds; drop reject-above-cap test - dto_mapping.rs / lib.rs: drop the upper-cap rejection tests - lib.rs verify_tee: rework the kickout-refusal fixture to break the relation via the participant-count ceiling instead of the cap - running.rs: make the reconstruction>governance test regenerate until gov < n - sandbox + e2e + node resharing tests: restore original participant/threshold values - docs/design/domain-separation.md: describe the cap as disabled (100%) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…hreshold' of github.com:near/mpc into 3499-correlate-governancethreshold-with-reconstructionthreshold

…hreshold' of github.com:near/mpc into 3499-correlate-governancethreshold-with-reconstructionthreshold # Conflicts: # crates/contract/src/dto_mapping.rs

Co-authored-by: Mårten Blankfors <marten@blankfors.se>

…st (#3805)

gilcu3

LGTM

Left only minor comments. Slightly concerned about some tests becoming flaky, but that's all.

gilcu3 · 2026-07-17T11:53:49Z

+            c.triples_to_buffer = 2;
+            c.presignatures_to_buffer = 2;


we usually put enough triples in the buffer for all the signatures in the test to try to avoid flakiness as much as possible.

gilcu3 · 2026-07-17T11:57:06Z

+    tokio::select! {
+        res = wait_metric_on_nodes(
+            &cluster,
+            &[0, 1, 2, 3, 4],
+            metrics::TIMEOUTS_INDEXED,
+            |v| v >= 1,
+            CLUSTER_WAIT_TIMEOUT,
+        ) => res.unwrap_or_else(|_| panic!(
+            "{} did not reach 1 on the surviving nodes — Cait-Sith request was answered \
+             despite only 5 of its 6 required signers being alive",
+            metrics::TIMEOUTS_INDEXED
+        )),


How long will this take? The timeout of a signature, 60 seconds?

No, it's the default 200 blocks of yield_timeout_length_in_blocks

kevindeforth

found a comment that wasn't addressed.

kevindeforth · 2026-07-17T13:06:36Z

+/// Sign with every scheme in `running`, asserting each request succeeds.
+pub async fn sign_all_schemes(
+    cluster: &MpcCluster,
+    running: &RunningContractState,
+    rng: &mut impl rand::Rng,
+) {


@SimonRastikian I don't think this comment was addressed.

kevindeforth

Thank you, looks good.
I still have one file to review, but please proceed by resolving conflicts with the base branch.

kevindeforth · 2026-07-21T09:46:10Z

+                debug_assert_eq!(
+                    participants.len(),
+                    threshold.value(),
+                    "triple routing infers t from channel size (see run_triple_generation_follower)"
+                );


yes, please remove it. We run tests in release mode in CI, so I doubt this will do anything.

kevindeforth · 2026-07-21T09:49:00Z


 pub const SUPPORTED_TRIPLE_GENERATION_BATCH_SIZE: usize = 64;

+const TRIPLE_METRICS_REPORTING_INTERVAL: Duration = Duration::from_millis(500);


This seems a bit aggressive for a pure monitoring function. We lock a mutex each time we call this.

I think every 5 seconds is sufficient here.

kevindeforth

Approved with 80% confidence (in my own review - pretty sure there are some things that I wouldn't catch here).
Would have been helpful to break this into smaller PRs.

gilcu3

Thank you again for the hard work. If we have still some doubts after this big change, we can always add more test coverage before the next release if needed.

kevindeforth

Thank you!

SimonRastikian and others added 30 commits June 15, 2026 23:12

make the two threshold DTO conversions fallible & validating

02dd798

Adding validation (upper cap and wrt the ReconstructionThreshold)

44e9e76

Updating tests now GovThreshold is capped at 80% no more allowed the …

7d86856

…same number of participants

Panic in migration misconfig

b33f455

Remove migration function after migration

02c5313

Raising the number of participants in the test to meet the 80% upper cap

a378c56

Raising extra tests number of particpants to meet the 80% cap

3da1652

Adding note documentation about cases where the threshold is a single…

aeed6e7

… possible value due to 60%-80% range

Using already existent helpers in vote_add_domains

7257a16

Bump the number of participants for parallel_sign_calls to meet 80% u…

a20a7a8

…pper cap

make process_new_parameters_proposal self-contained

1afd958

Removing redundant function

db47b85

Obsolete test as the check happens in the underlying function

0cf1b53

make function private

27e40bf

Fixing tests with govthreshold = number of participants

7878ac8

More participants during resharing

1f28966

Raising the number of participants to 7

7bca4d8

Using governance_threshold_lower_bound and governance_threshold_upper…

263bc8d

…_bound as helpers

cargo fmt

f45ebf5

reducing code redundancy

c8fec49

Some more redundancy reduction

6e1ce47

Merge branch 'main' into 3499-correlate-governancethreshold-with-reco…

5056109

…nstructionthreshold

Merge branch '3499-correlate-governancethreshold-with-reconstructiont…

fbf22be

…hreshold' of github.com:near/mpc into 3499-correlate-governancethreshold-with-reconstructionthreshold

delimiter fix

b310e84

Merge branch '3499-correlate-governancethreshold-with-reconstructiont…

ca8b199

…hreshold' of github.com:near/mpc into 3499-correlate-governancethreshold-with-reconstructionthreshold # Conflicts: # crates/contract/src/dto_mapping.rs

Update crates/contract/src/v3_11_2_state.rs

da2d190

Co-authored-by: Mårten Blankfors <marten@blankfors.se>

using ReconstructionThreshold as u64 and using checked arithmetic

7458432

Using 1 as values

4f52bdd

editting doc to make fast ci check pass

29613b8

SimonRastikian added 4 commits July 16, 2026 18:49

Fixing deeper issues following merge with main

96535d6

Removing a test by extending another

9ca92e1

test: remove redundant static multidomain reconstruction-threshold te…

e350511

…st (#3805)

Merge branch 'main' into 3164-adding-ReconstructionThreshold-in-node

5d3fedc

SimonRastikian requested review from gilcu3 and kevindeforth July 16, 2026 17:46

gilcu3 previously approved these changes Jul 17, 2026

View reviewed changes

kevindeforth reviewed Jul 17, 2026

View reviewed changes

signing for all domains instead of all schemes

9231d99

SimonRastikian dismissed gilcu3’s stale review via 9231d99 July 17, 2026 17:10

Using variables

4ab6098

kevindeforth reviewed Jul 21, 2026

View reviewed changes

SimonRastikian added 2 commits July 21, 2026 12:56

Solving conflicts

3e3af3b

Removing debug_assert_eq

da56e05

kevindeforth previously approved these changes Jul 21, 2026

View reviewed changes

gilcu3 previously approved these changes Jul 21, 2026

View reviewed changes

Comment thread crates/e2e-tests/tests/common.rs

Deleting useless input in struct

97a24ae

SimonRastikian dismissed stale reviews from gilcu3 and kevindeforth via 97a24ae July 21, 2026 12:32

Less aggressive timing

c09f549

SimonRastikian enabled auto-merge July 21, 2026 12:37

kevindeforth approved these changes Jul 21, 2026

View reviewed changes

gilcu3 approved these changes Jul 21, 2026

View reviewed changes

SimonRastikian added this pull request to the merge queue Jul 21, 2026

Merged via the queue into main with commit b9eed26 Jul 21, 2026
15 checks passed

SimonRastikian deleted the 3164-adding-ReconstructionThreshold-in-node branch July 21, 2026 13:03

gilcu3 mentioned this pull request Jul 23, 2026

Test resharing with a changed reconstruction threshold for Frost, CKD, and DamgardEtAl #3926

Closed

claude Bot mentioned this pull request Jul 24, 2026

chore: job restart not needed when governance threshold changes #3955

Merged

SimonRastikian mentioned this pull request Aug 4, 2026

test: Assert onchain timeout in recon test #4051

Open


		pub const SUPPORTED_TRIPLE_GENERATION_BATCH_SIZE: usize = 64;

		const TRIPLE_METRICS_REPORTING_INTERVAL: Duration = Duration::from_millis(500);

Uh oh!

Conversation

SimonRastikian commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gilcu3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gilcu3 Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

gilcu3 Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

SimonRastikian Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevindeforth left a comment

Choose a reason for hiding this comment

Uh oh!

kevindeforth Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

kevindeforth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevindeforth Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

kevindeforth Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

SimonRastikian Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kevindeforth left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gilcu3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevindeforth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SimonRastikian commented Jun 22, 2026 •

edited

Loading

kevindeforth left a comment •

edited

Loading