ci: lower contract WASM size limit to 1235000

[pbeza]

Current contract size: 1,175,891 bytes (≈1.12 MiB).

Closes #3904

[Copilot]

Pull request overview

This PR tightens the CI guardrail that enforces the on-chain contract’s deployable WASM size, reducing the hard cap to better prevent gradual size creep toward NEAR’s max_transaction_size limit.

Changes:

• Lowered the contract WASM HARD_LIMIT from 1520000 to 1235000 bytes (≈5% headroom over the reported reproducible-build size).
• Replaced stale, PR/issue-specific historical commentary with an evergreen explanation of the limit’s purpose and maintenance intent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[claude]

Pull request overview

Ratchets down HARD_LIMIT in scripts/check-contract-wasm-size.sh from 1520000 to 1235000 to keep the CI creep guard meaningful now that the contract shrank to ~1,175,891 bytes (after dropping dcap-qvl and the async TEE attestation changes). The stale, issue-specific comment history is replaced with a self-contained rationale block.

Changes:

• Lower HARD_LIMIT to 1235000 (~59 KB / ~5% headroom over the current reproducible-build size)
• Rewrite the accompanying comment to explain the invariant without tying it to now-closed issues (Implement voting mechanism for adding / removing allowed RPC provider #3215, Implement proposed design for available foreign chains for validation #3475)

Reviewed changes

Per-file summary

File	Description
scripts/check-contract-wasm-size.sh	Ratchet WASM HARD_LIMIT down to 1,235,000 and clean up the stale comment history.

Findings

Verified against the acceptance criteria in #3904: new limit matches (1,235,000), stale PR/issue-specific comments are removed, and the file-header comment (scripts/check-contract-wasm-size.sh:4-10) already explains the general rationale so the shortened inline comment doesn't lose context. Math checks out: 1,235,000 - 1,175,891 = 59,109 bytes of headroom (~5%), well below NEAR's max_transaction_size of 1,572,864.

No blocking issues.

✅ Approved

[netrome]

Nice, thanks!

[gilcu3]

Nice!