Skip to content

fix: Use threshold number for previous running state in resharing#480

Merged
4 commits merged intomainfrom
bookrock/fix-wait-for-ready
Jun 10, 2025
Merged

fix: Use threshold number for previous running state in resharing#480
4 commits merged intomainfrom
bookrock/fix-wait-for-ready

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 8, 2025

We have a checkpoint, wait_for_ready, in the running state that waits on a threshold number of participants are online before starting the running state. This check has two bugs:

  1. This check is done before spawning the resharing handle, which is not the correct behavior. The resharing handle should be spawned independently of the starting conditions of the running state.
  2. It should not use the threshold size of the new resharing state in case of resharings. The node needs to wait on a threshold number of the participants from the previous node set.

Both issues are fixed in this PR. This is consistent with the behavior previous to merging running and resharing state in the node

@ghost ghost changed the title fix: Threshold check for previous running state was using new resharing threshold fix: Use threshold number for previous running state in resharing Jun 8, 2025
@ghost ghost marked this pull request as ready for review June 8, 2025 22:36
Copy link
Copy Markdown
Contributor

@kevindeforth kevindeforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ghost ghost added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit f0116f4 Jun 10, 2025
1 check passed
@ghost ghost deleted the bookrock/fix-wait-for-ready branch June 10, 2025 08:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants