test: test that threshold from previous running state is used when serving sign requests in resharing#481
Merged
7 commits merged intomainfrom Jun 12, 2025
Merged
Conversation
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
self-assigned this
Contributor
kevindeforth
left a comment
kevindeforth
left a comment
There was a problem hiding this comment.
These pytests take quite a long time to run.
I would prefer to merge test_single_domain with test_threshold_from_previous_running_state_is_maintained, since the latter also covers the former.
If we want to test this behavior in isolation, we might be advised to implement a Rust integration test instead, since they are significantly faster.
ghost
enabled auto-merge
kevindeforth
approved these changes
Jun 12, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test to the issue that was solved in: #480
The test fails on
mainprevious to the merged fix.