Skip to content

SCHED-921: Pass tf vars in json#2151

Merged
theyoprst merged 1 commit intosoperator-release-2.0from
SCHED-921/escape-vars
Feb 10, 2026
Merged

SCHED-921: Pass tf vars in json#2151
theyoprst merged 1 commit intosoperator-release-2.0from
SCHED-921/escape-vars

Conversation

@theyoprst
Copy link
Copy Markdown
Collaborator

@theyoprst theyoprst commented Feb 10, 2026

Problem

Some tf var now contain quotes:

nvidia_admin_conf_lines = [
  "options nvidia NVreg_RestrictProfilingToAdminUsers=0", # Allow access to GPU counters in nsys profiler for non-root users
  "options nvidia NVreg_EnableStreamMemOPs=1",
+  "options nvidia NVreg_RegistryDwords=\"PeerMappingOverride=1;\"",
]

Because of that, terratest runs terraform with wrongly formatted vars:
-var nvidia_admin_conf_lines=["options nvidia NVreg_RestrictProfilingToAdminUsers=0", "options nvidia NVreg_EnableStreamMemOPs=1", "options nvidia NVreg_RegistryDwords="PeerMappingOverride=1;""]

And it leads to terraform errors:

TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: Error: Missing item separator
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: 
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67:   on <value for var.nvidia_admin_conf_lines> line 1:
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67:   (source code not available)
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: 
TestTerraformDestroy 2026-02-10T08:16:15Z logger.go:67: Expected a comma to mark the beginning of the next item.

Solution

Pass vars as a JSON, which already does proper escaping.

Testing

https://github.com/nebius/soperator/actions/runs/21860154458/job/63086857937
(cancelled after successful passed the problematic point)

…sues in e2e tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@theyoprst theyoprst added the ignore-for-release Don't include this PR into changelog label Feb 10, 2026
@theyoprst theyoprst changed the title [SCHED-921] Implement a robust fix for escaping issues of tf vars SCHED-921: Pass tf vars in json Feb 10, 2026
@theyoprst theyoprst marked this pull request as ready for review February 10, 2026 10:33
@theyoprst theyoprst merged commit 6da18d4 into soperator-release-2.0 Feb 10, 2026
10 of 12 checks passed
@theyoprst theyoprst deleted the SCHED-921/escape-vars branch February 10, 2026 10:38
@theyoprst theyoprst added the e2e e2e improvements / changes / speedups label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e e2e improvements / changes / speedups ignore-for-release Don't include this PR into changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants